[Silabs] Fix some uart cli hang #35723
Merged
+103
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
jmartinez-silabs
added
the
changing-submodules-on-purpose
…use our UartConsole api when SILABS_LOG_OUT_UART is enabled
jmartinez-silabs
force-pushed
the
fix/uart_hang
branch
from
ecca337 to
38cebd8
Compare
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex and
harsha-rajendran
pullapprove
bot
requested review from
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #35723: Size comparison from 17f25a1 to 38cebd8 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
lpbeliveau-silabs
approved these changes
Sep 23, 2024
andy31415
reviewed
Sep 24, 2024
andy31415
reviewed
Sep 24, 2024
andy31415
approved these changes
Sep 24, 2024
Co-authored-by: Andrei Litvin <[email protected]>
|
PR #35723: Size comparison from 17f25a1 to 0357ad3 Full report (49 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
|
PR #35723: Size comparison from 17f25a1 to 8b131f9 Increases above 0.2%:
Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
* Add macros to abstact eusart api between series * Fix for uart cpp with irq handling with series3. Tweak uart and shell task priority. * [MATTER-4132]force implementation of _read and _write from newlib to use our UartConsole api when SILABS_LOG_OUT_UART is enabled * remove segger_rtt_syscalls when uartlog is enabled * Apply suggestions from code review Co-authored-by: Andrei Litvin <[email protected]> * Restyled by gn --------- Co-authored-by: Andrei Litvin <[email protected]> Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Application hang can occur in UART cli processing ( Matter shell, or otcli) when a large amount of data is suddenly written in the input buffer like a copy-paste for example.
FIX:
On the irq handler, disable EUSART_IF_RXFL (data available in fifo) until the processing task can retrieve it.
Other changes
_writeand_readsysstubs when our uart log is enabled to accommodate some Silabs internal cli functions.